-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Description
In going through the code the robot class doesn't seem to add much (for the time being). It's only used in 3 places to do the following:
Getting pose -- which should probably be done through TF anyhow
Sending velocity to base -- which should only be done by the controller, that can just be 1 line config for topic.
Its an additional package that adds a certain level of complexity without much existing benefit. I propose removing the robot class entirely, and revisiting this concept when other elements of the system are stable. I like the idea of a centralized class where we can define the motion model, certain high level parameters, and description information, however it doesnt seem to be on the priority list of things to work on and the existing state of the project makes it hard to read and understand where this is potentially going.
We've had alot of good ideas and thought but this one in particular wasn't fully thought out and I think its worth removing and restarting when we have better defined requirements and there's someone willing to put extended time into pulling all the robot specific elements into that class.
Lets discuss below. If we agree, I can do this.
This is in line with #691 of my attempt to make the project more linear to read and understand.