-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Feature request
Feature description
An OpaqueFunction is used with ParseMultiRobotPose to repeat entities based on values in a launch argument. For example, see cloned_multi_tb3_simulation_launch.py
As of ros2/launch#802, launch has a ForEach action to do the same thing. See this ROS Discourse comment.
Update Nav2 to use ForEach instead of OpaqueFunction + ParseMultiRobotPose.
Implementation considerations
Steps:
- In every launch file where
OpaqueFunction+ParseMultiRobotPoseare used:- Change the launch file to use a
ForEachaction instead of anOpaqueFunction - Make the existing
generate_robot_actions()function theForEachaction'sfunction, and turn the values parsed byParseMultiRobotPoseinto parameters of the function, with default values wherever appropriate - Provide the
LaunchConfiguration()to theForEachaction instead ofParseMultiRobotPose
- Change the launch file to use a
- Consider deprecating
ParseMultiRobotPose
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed