-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Description
There is potentially a minor bug / unused code in the twirling dwb critic with the scale parameter.
The condition in the code above will always be false since the parameter would have been already declared in:https://github.com/ros-planning/navigation2/blob/7c0ac74514506591c0d508a6bc10e42d1d67162f/nav2_dwb_controller/dwb_core/include/dwb_core/trajectory_critic.hpp#L104-L108
Therefore the twirling parameter scale will always be 1.
Is the intention for the default twirling parameter scale to be 0 or 1?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels