Document gracefull cancellation API#535
Merged
SteveMacenski merged 5 commits intoros-navigation:masterfrom Mar 28, 2024
Merged
Conversation
9 tasks
Member
SteveMacenski
left a comment
There was a problem hiding this comment.
Please add to migration guide - this is a good new features for folks to be aware of :-)
e961ff5 to
2704a03
Compare
Contributor
Author
|
I've added it to the migration guide |
SteveMacenski
approved these changes
Mar 27, 2024
Member
|
@Rayman your fork doesn't let me commit to it with the suggestion, but after that can merge |
Signed-off-by: Ramon Wijnands <ramon.wijnands@nobleo.nl>
Signed-off-by: Ramon Wijnands <ramon.wijnands@nobleo.nl> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Ramon Wijnands <ramon.wijnands@nobleo.nl>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
53a0ed4 to
ab532af
Compare
SteveMacenski
approved these changes
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after ros-navigation/navigation2#4136 is merged