Skip to content

Description of BT plugins for follow pose behavior#40

Merged
SteveMacenski merged 5 commits intoros-navigation:masterfrom
fmrico:follow_pose_bt_plugins
Aug 10, 2020
Merged

Description of BT plugins for follow pose behavior#40
SteveMacenski merged 5 commits intoros-navigation:masterfrom
fmrico:follow_pose_bt_plugins

Conversation

@fmrico
Copy link
Copy Markdown
Contributor

@fmrico fmrico commented Jul 9, 2020

BT Plugins for ros-navigation/navigation2#1859

Signed-off-by: Francisco Martin Rico fmrico@gmail.com

@SteveMacenski
Copy link
Copy Markdown
Member

Lets wait until we have the other PR where we know the names / variables that are still open for change.

But in addition to this:

  • Add these BT nodes and new follow goal capability to migration guide
  • Add these new plugins to the navigation plugins page & add yourself as the author (https://navigation.ros.org/plugins/index.html)
  • I'd really appreciate a short tutorial "Dynamic Point Following" or "Moving Carrot Follower" or something explaining the goal of the work (have robot follow something moving), showing the behavior tree and explaining how it works, and the requirements (something publishing the object pose to follow). This is good, commonly asked for capability and deserves white glove support
  • Main page (https://navigation.ros.org/index.html) says point A to B navigation, if that's no longer the case with this, we should update this to include this new capability or at least make it less specific.

@fmrico
Copy link
Copy Markdown
Contributor Author

fmrico commented Jul 25, 2020

Hi @SteveMacenski

Documentation for ros-navigation/navigation2#1859 added.

Copy link
Copy Markdown
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmrico please build locally, you have a bunch of things that would have been immediate to you if you checked builds or logs.

@SteveMacenski
Copy link
Copy Markdown
Member

@fmrico please make this update so we can update our docs for the capabilities already merged

@fmrico
Copy link
Copy Markdown
Contributor Author

fmrico commented Jul 29, 2020

Hi @SteveMacenski, I am currently out of my house on holidays, but I understand that this is urgent. I will try to do it in the next couple of days.

@SteveMacenski
Copy link
Copy Markdown
Member

Not that urgent, just make sure to take a look at this once you're back. Don't worry about it until then :-)

@fmrico
Copy link
Copy Markdown
Contributor Author

fmrico commented Aug 6, 2020

Hi @SteveMacenski

I have just done all the changes. Many errors that you commented were because I didn't render the page (I had never used sphinx until now). Now I have rendered the page, removing all errors and warnings.

Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
@fmrico fmrico force-pushed the follow_pose_bt_plugins branch from b99a118 to 2f7b81f Compare August 6, 2020 06:15
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
@fmrico
Copy link
Copy Markdown
Contributor Author

fmrico commented Aug 6, 2020

Ok @SteveMacenski . I have just fixed the problem with the merge.

Now you can review :)

Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
Copy link
Copy Markdown
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add these new plugins to the navigation plugins page & add yourself as the author (https://navigation.ros.org/plugins/index.html)

My request for a tutorial stands, but that's not blocking this PR

fmrico added 2 commits August 10, 2020 18:46
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
@SteveMacenski
Copy link
Copy Markdown
Member

SteveMacenski commented Aug 10, 2020

Awesome, thanks!

I'd still be more than happy to have a short tutorial / feature description on this showing how to use that BT for dynamic point following in your context. (e.g. change BT to use, gifs working, explain how you do detection, etc)

This is a commonly requested capability, having some details on how to use them could really help alot of people #56

@SteveMacenski SteveMacenski merged commit e2e479c into ros-navigation:master Aug 10, 2020
@fmrico fmrico deleted the follow_pose_bt_plugins branch August 13, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants