Skip to content

add docs for waitUntilNav2Active#275

Merged
SteveMacenski merged 2 commits intoros-navigation:masterfrom
tonynajjar:add-optional-node-names-to-wait
Feb 12, 2022
Merged

add docs for waitUntilNav2Active#275
SteveMacenski merged 2 commits intoros-navigation:masterfrom
tonynajjar:add-optional-node-names-to-wait

Conversation

@tonynajjar
Copy link
Contributor

@tonynajjar tonynajjar commented Feb 8, 2022

Docs for ros-navigation/navigation2#2811

Additionally fixed some extra white spaces

| | active state. To be used in conjunction with autostart or external |
| | lifecycle bringup. |
| waitUntilNav2Active( | Blocks until Nav2 is completely online and lifecycle nodes are in the |
| navigator='bt_navigator', | active state. To be used in conjunction with autostart or external | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is misformatted, the table isn't rendering in github's markdown view or in the rst website https://1251-240847415-gh.circle-artifacts.com/0/html/commander_api/index.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, in the artifacts waitUntilNav2Active is shown as bold. In an RST viewer I found online it looks fine.

How can I test it on the Read The Docs viewer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 ways, you can compile it locally, see the ci config for the libraries to install and then you can invoke “make html” to make it. Then look in the build directory for the html’s entry index to view in a browser. Also, it you run it through CI, you can go to the artifacts tab and do the same thing with CI’s output build.

@SteveMacenski SteveMacenski merged commit 1d62986 into ros-navigation:master Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants