This repository was archived by the owner on Oct 23, 2025. It is now read-only.
Update REP-142 with some fixes found during REP-150 review.#165
Merged
clalancette merged 1 commit intomasterfrom Mar 19, 2018
Merged
Update REP-142 with some fixes found during REP-150 review.#165clalancette merged 1 commit intomasterfrom
clalancette merged 1 commit intomasterfrom
Conversation
In particular:
1. Remove "extends" from "ros_core" definition, since extends
is meant to be used for other meta-packages.
2. Add "ros" and "ros_comm" into "ros_core" package list.
3. Remove "console_bridge" from "ros_core" packages, since
it is provided by the system since Trusty (Indigo).
4. Move "angles" from "ros_base" to "desktop", since it is
a dependency of common_tutorials.
5. Make viz extend from "ros_base" instead of "robot".
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
dirk-thomas
approved these changes
Mar 19, 2018
mikaelarguedas
approved these changes
Mar 19, 2018
Contributor
|
@dirk-thomas how should we proceed on the metapackages side? update the indigo-devel and kinetic-devel branches accordingly but not the jade-devel as Jade is EOL? |
Member
|
I would ask @clalancette to create follow up PRs against all branches. And after they have been merged we only release into non-EOL distros. |
Contributor
Author
Doing that now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In particular:
is meant to be used for other meta-packages.
it is provided by the system since Trusty (Indigo).
a dependency of common_tutorials.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org