This repository was archived by the owner on Oct 23, 2025. It is now read-only.
Merged
Conversation
This was referenced Dec 4, 2017
mikaelarguedas
approved these changes
Dec 4, 2017
Contributor
mikaelarguedas
left a comment
There was a problem hiding this comment.
lgtm,
Note that I didnt follow the full discussion about the addition of these operators and how they should perform. Though comparing string seems good to me (bash-like).
jack-oquin
reviewed
Dec 23, 2017
| * All literals are also treated as strings. | ||
| * The resulting expression is evaluated as a Python interpreter would | ||
| evaluate it. | ||
| Please not that the comparison operators only do a *string* comparison and |
Contributor
There was a problem hiding this comment.
Typo: not should be note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the feedback in #138. While we might not want to recommend using these operators for comparing the ROS distro name (since they will "wrap" in the future) we will provide the operators. So the user can choose if / what they want to use it for.