Skip to content

[KM] Remove ignore list.#6

Merged
130s merged 1 commit intoros-gbp:masterfrom
130s:release_chomp
Oct 24, 2018
Merged

[KM] Remove ignore list.#6
130s merged 1 commit intoros-gbp:masterfrom
130s:release_chomp

Conversation

@130s
Copy link
Copy Markdown
Member

@130s 130s commented Oct 24, 2018

To make a release for Kinetic moveit/moveit#1083 (comment), I still faced an error upon bloom (*1) that complains moveit_experimental is not available as a .deb.

moveit_experimental seems to be depended on only by chomp pkgs (*2), so hopefully getting it released is less harmful even if there's an issue (I can't think of any better way to confirm that, other than releasing them and cross fingers :O).

*1

$ bloom-release --rosdistro kinetic --track kinetic moveit
:
==> git-bloom-generate -y rosdebian --prefix release/kinetic kinetic -i 0 --os-name ubuntu
Explicitly ignoring package 'moveit_experimental' because it is in the `kinetic.ignored` file.
Generating source debs for the packages: ['moveit_ros_move_group', 'moveit_core', 'moveit_planners', 'moveit_kinematics', 'moveit_simple_controller_manager', 'moveit_controller_manager_example', 'moveit_planners_ompl', 'moveit_ros_planning', 'moveit_ros_manipulation', 'moveit_ros_control_interface', 'moveit_planners_chomp', 'moveit_ros_warehouse', 'moveit', 'moveit_fake_controller_manager', 'chomp_motion_planner', 'moveit_plugins', 'moveit_ros_robot_interaction', 'moveit_ros_benchmarks', 'moveit_ros_visualization', 'moveit_ros_planning_interface', 'moveit_commander', 'moveit_ros_perception', 'moveit_setup_assistant', 'moveit_runtime', 'moveit_ros']
Debian Incremental Version: 0
Debian Distributions: ['xenial']
Releasing for rosdistro: kinetic

Pre-verifying Debian dependency keys...
Running 'rosdep update'...
Could not resolve rosdep key 'moveit_experimental'
Failed to resolve moveit_experimental on ubuntu:xenial with: Error running generator: Failed to resolve rosdep key 'moveit_experimental', aborting.
moveit_experimental is depended on by these packages: ['chomp_motion_planner', 'moveit_planners_chomp']
<== Failed
Some of the dependencies for packages in this repository could not be resolved by rosdep.
You can try to address the issues which appear above and try again if you wish.
Would you like to try again? [Y/n]? n
User aborted after rosdep keys were not resolved.
<== The following generator action reported that it is missing one or more
    rosdep keys, but that the key exists in other platforms:
'['/usr/bin/git-bloom-generate', '-y', 'rosdebian', '--prefix', 'release/kinetic', 'kinetic', '-i', '0', '--os-name', 'ubuntu']'

If you are absolutely sure that this key is unavailable for the platform in
question, the generator can be skipped and you can proceed with the release.

*2

$ ack-grep -i "moveit_experimental" .
moveit/CHANGELOG.rst
74:* [fix][moveit_experimental] remove explicit fcl depends `#632 <https://github.com/ros-planning/moveit/pull/632>`_

moveit_ros/planning/planning_request_adapter_plugins/CMakeLists.txt
27:  ../../../moveit_experimental/collision_distance_field/include/)

moveit_experimental/CMakeLists.txt
2:project(moveit_experimental)

moveit_experimental/package.xml
2:  <name>moveit_experimental</name>

moveit_experimental/CHANGELOG.rst
2:Changelog for package moveit_experimental
70:* [moveit_experimental] Fix incorrect dependency on FCL in kinetic
71:  [moveit_experimental] Fix Eigen3 warning
89:  * Add install targets in moveit_experimental and chomp

moveit_planners/chomp/chomp_interface/CMakeLists.txt
12:  moveit_experimental

moveit_planners/chomp/chomp_interface/package.xml
22:  <build_depend>moveit_experimental</build_depend>

moveit_planners/chomp/chomp_interface/CHANGELOG.rst
83:  * Add install targets in moveit_experimental and chomp

moveit_planners/chomp/chomp_motion_planner/CMakeLists.txt
6:find_package(catkin REQUIRED COMPONENTS roscpp moveit_experimental moveit_core)

moveit_planners/chomp/chomp_motion_planner/package.xml
18:  <build_depend>moveit_experimental</build_depend>

moveit_planners/chomp/chomp_motion_planner/CHANGELOG.rst
74:  * Add install targets in moveit_experimental and chomp
$ git log -1
commit 95050e3a1a873f2a3a12af1eb3c7b96efc43ec8d
Merge: 2903081 89ed372
Author: Isaac I.Y. Saito <130s@users.noreply.github.com>
Date:   Wed Oct 24 10:54:30 2018 -0700

    Merge pull request #1127 from 130s/release_chompif/k

    Include chomp packages in a dependency chain starting from moveit metapkg

To make a release for Kinetic moveit/moveit#1083 (comment), I still faced an error upon `bloom` (*1) that complains `moveit_experimental` is not available as a .deb.

`moveit_experimental` seems to be depended on only by chomp pkgs (*2), so hopefully getting it released is less harmful even if there's an issue (I can't think of any better way to confirm that, other than releasing them and cross fingers :O).

*1
```
$ bloom-release --rosdistro kinetic --track kinetic moveit
:
==> git-bloom-generate -y rosdebian --prefix release/kinetic kinetic -i 0 --os-name ubuntu
Explicitly ignoring package 'moveit_experimental' because it is in the `kinetic.ignored` file.
Generating source debs for the packages: ['moveit_ros_move_group', 'moveit_core', 'moveit_planners', 'moveit_kinematics', 'moveit_simple_controller_manager', 'moveit_controller_manager_example', 'moveit_planners_ompl', 'moveit_ros_planning', 'moveit_ros_manipulation', 'moveit_ros_control_interface', 'moveit_planners_chomp', 'moveit_ros_warehouse', 'moveit', 'moveit_fake_controller_manager', 'chomp_motion_planner', 'moveit_plugins', 'moveit_ros_robot_interaction', 'moveit_ros_benchmarks', 'moveit_ros_visualization', 'moveit_ros_planning_interface', 'moveit_commander', 'moveit_ros_perception', 'moveit_setup_assistant', 'moveit_runtime', 'moveit_ros']
Debian Incremental Version: 0
Debian Distributions: ['xenial']
Releasing for rosdistro: kinetic

Pre-verifying Debian dependency keys...
Running 'rosdep update'...
Could not resolve rosdep key 'moveit_experimental'
Failed to resolve moveit_experimental on ubuntu:xenial with: Error running generator: Failed to resolve rosdep key 'moveit_experimental', aborting.
moveit_experimental is depended on by these packages: ['chomp_motion_planner', 'moveit_planners_chomp']
<== Failed
Some of the dependencies for packages in this repository could not be resolved by rosdep.
You can try to address the issues which appear above and try again if you wish.
Would you like to try again? [Y/n]? n
User aborted after rosdep keys were not resolved.
<== The following generator action reported that it is missing one or more
    rosdep keys, but that the key exists in other platforms:
'['/usr/bin/git-bloom-generate', '-y', 'rosdebian', '--prefix', 'release/kinetic', 'kinetic', '-i', '0', '--os-name', 'ubuntu']'

If you are absolutely sure that this key is unavailable for the platform in
question, the generator can be skipped and you can proceed with the release.
```

*2
```
$ ack-grep -i "moveit_experimental" .
moveit/CHANGELOG.rst
74:* [fix][moveit_experimental] remove explicit fcl depends `#632 <https://github.com/ros-planning/moveit/pull/632>`_

moveit_ros/planning/planning_request_adapter_plugins/CMakeLists.txt
27:  ../../../moveit_experimental/collision_distance_field/include/)

moveit_experimental/CMakeLists.txt
2:project(moveit_experimental)

moveit_experimental/package.xml
2:  <name>moveit_experimental</name>

moveit_experimental/CHANGELOG.rst
2:Changelog for package moveit_experimental
70:* [moveit_experimental] Fix incorrect dependency on FCL in kinetic
71:  [moveit_experimental] Fix Eigen3 warning
89:  * Add install targets in moveit_experimental and chomp

moveit_planners/chomp/chomp_interface/CMakeLists.txt
12:  moveit_experimental

moveit_planners/chomp/chomp_interface/package.xml
22:  <build_depend>moveit_experimental</build_depend>

moveit_planners/chomp/chomp_interface/CHANGELOG.rst
83:  * Add install targets in moveit_experimental and chomp

moveit_planners/chomp/chomp_motion_planner/CMakeLists.txt
6:find_package(catkin REQUIRED COMPONENTS roscpp moveit_experimental moveit_core)

moveit_planners/chomp/chomp_motion_planner/package.xml
18:  <build_depend>moveit_experimental</build_depend>

moveit_planners/chomp/chomp_motion_planner/CHANGELOG.rst
74:  * Add install targets in moveit_experimental and chomp
```
```
$ git log -1
commit 95050e3a1a873f2a3a12af1eb3c7b96efc43ec8d
Merge: 2903081 89ed372
Author: Isaac I.Y. Saito <130s@users.noreply.github.com>
Date:   Wed Oct 24 10:54:30 2018 -0700

    Merge pull request #1127 from 130s/release_chompif/k

    Include chomp packages in a dependency chain starting from moveit metapkg
```
@rhaschke
Copy link
Copy Markdown
Contributor

Closing in favour of moveit/moveit#1129.

@rhaschke rhaschke closed this Oct 24, 2018
@rhaschke rhaschke reopened this Oct 24, 2018
Copy link
Copy Markdown
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve. moveit_experimental is indeed still needed (collision_distance_field stuff).

@130s 130s merged commit 741508f into ros-gbp:master Oct 24, 2018
@130s 130s deleted the release_chomp branch October 24, 2018 21:50
@rhaschke rhaschke mentioned this pull request Oct 25, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants