Deprecating tf2 C Headers#1325
Conversation
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
saikishor
left a comment
There was a problem hiding this comment.
@CursedRock17 is this from rolling on? or does it affect Jazzy as well?
|
This is from rolling onward, there aren't any plans of back porting yet. |
Thank you! We will have to wait for the original PR to be merged and then we can get back to this. |
|
@CursedRock17 I changed this PR to draft for now. Once your original PR is merged, please mark it as ready |
|
With the recent backports merged, this PR should be good for review. |
|
The backport to jazzy hasn't been released yet, and on rolling it seems that they are not yet available on testing repo although the PR on rosdistro was merged. Let's wait until then, then we could merge because the binary-main jobs are failing already because we did the same with realtime_tools headers. |
|
This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1325 +/- ##
=======================================
Coverage 84.79% 84.79%
=======================================
Files 127 127
Lines 12114 12114
Branches 1036 1036
=======================================
Hits 10272 10272
Misses 1503 1503
Partials 339 339
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christophfroehlich
left a comment
There was a problem hiding this comment.
@CursedRock17 as the upstream changes got synced we can go on with this.
Do you mind also fixing the occurrences of tf2/transform_datatypes.h this repo?
Related to this pull request in
geometry2in which we deprecated the.hstyle headers in favor of.hpp.