Skip to content

[JTC] Need for start_with_holding option? #816

@christophfroehlich

Description

@christophfroehlich

During discussions with @saikishor about #811 the question came up, if start_with_holding=false behavior is useful at all?

The code could be simplified if the default start_with_holding=true is the only option.

Some context: the set_hold_position feature from #558 was motivated from the following PRs/issues:

I can't remember now anyone asking for set_hold_position=false functionality. This was the behavior before #558 and added for legacy reasons.

Is there a use-case for this or should we delete this option and don't confuse people with it? See #801 (comment)
As it wasn't backported to humble yet, I think there is not a big use of the current behavior and no one would miss it.

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions