Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2589 +/- ##
==========================================
+ Coverage 89.42% 89.44% +0.02%
==========================================
Files 151 151
Lines 17036 17027 -9
Branches 1412 1412
==========================================
- Hits 15234 15230 -4
+ Misses 1243 1237 -6
- Partials 559 560 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
requested changes
Oct 2, 2025
Member
saikishor
left a comment
There was a problem hiding this comment.
Overall looks good to me. Just few nitpicks
controller_interface/test/test_semantic_component_command_interface.cpp
Outdated
Show resolved
Hide resolved
This was referenced Oct 2, 2025
Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Contributor
|
This pull request is in conflict. Could you fix it @christophfroehlich? |
saikishor
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs ros-controls/ros2_controllers#1936 to be merged first