Skip to content

Add new joint handles to test_robot_hardware#136

Merged
bmagyar merged 2 commits intoros-controls:masterfrom
pal-robotics-forks:test_hardware_dynamic_joint_handles
Sep 2, 2020
Merged

Add new joint handles to test_robot_hardware#136
bmagyar merged 2 commits intoros-controls:masterfrom
pal-robotics-forks:test_hardware_dynamic_joint_handles

Conversation

@jordan-palacios
Copy link
Copy Markdown
Member

@jordan-palacios jordan-palacios commented Aug 28, 2020

See #124.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 28, 2020 •
edited by codecov bot
Loading

Codecov Report

❌ Patch coverage is 24.48980% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.54%. Comparing base (b6a50df) to head (f032391).
⚠️ Report is 1131 commits behind head on master.

Files with missing lines Patch % Lines
test_robot_hardware/src/test_robot_hardware.cpp 3.57% 15 Missing and 12 partials ⚠️
...ot_hardware/test/test_robot_hardware_interface.cpp 52.38% 0 Missing and 10 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   43.32%   43.54%   +0.21%     
==========================================
  Files          42       42              
  Lines        1424     1410      -14     
  Branches      786      761      -25     
==========================================
- Hits          617      614       -3     
- Misses         85      112      +27     
+ Partials      722      684      -38
Flag Coverage Δ
unittests 43.54% <24.48%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jordan-palacios jordan-palacios mentioned this pull request Aug 31, 2020
Merged
@jordan-palacios
Copy link
Copy Markdown
Member Author

jordan-palacios commented Aug 31, 2020

@Karsten1987 can you take a look at this, please ? One of the ros industrial CI is failing in what looks like an unrelated package.

@bmagyar bmagyar mentioned this pull request Sep 2, 2020
Closed
@bmagyar
Copy link
Copy Markdown
Member

bmagyar commented Sep 2, 2020

I find it very funny how the copyright linter started failing as soon as I disabled the other build but I'll resist the urge of disabling everything that fails. Let's roll in with it being broken, hopefully it's a temporary failure on the runner.

@bmagyar bmagyar merged commit b9ea092 into ros-controls:master Sep 2, 2020
@jordan-palacios jordan-palacios deleted the test_hardware_dynamic_joint_handles branch September 2, 2020 14:48
@jordan-palacios jordan-palacios mentioned this pull request Sep 2, 2020
Closed
4 tasks
@destogl destogl mentioned this pull request Nov 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmagyar bmagyar bmagyar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jordan-palacios @codecov-commenter @bmagyar