Conversation
- Moved contents from "src/xacro/" folder to "xacro/" folder. - Renamed scripts folder to resource folder. - Modifed package.xml and setup.py according to ROS2 rules. - Deleted CMakeLists.txt
- Modified all python scripts as per ros2 coding guidelines. - Added substitution_args.py file, replacement for roslaunch's resolve_args() method, as it is not available in ROS2's ros2launch package. - Updated shebang line in all python scripts to use python3. - Resolved errors where some test cases were failing to find out some .xml files. (eg. include1.xml) - Added temporary workaround for rosgraph.names.load_mappings because rosgraph is not migrated to ROS2.
…, required for ament_copyright rule.
…test this package on bouncy.
- Added some more details in README.md file.
|
Is there any chance this is reviewed and released soon? |
|
Sorry for being unresponsive on this. I am too busy with other projects and I didn't familiarize myself with ROS2 yet. Hopefully, I can find some time during my summer holidays, i.e. during the next 4 weeks to work on this.
Would be great, if you, @vandanamandlik or @kazuki0824, could prepare this. |
|
Is there an example somewhere showing how to parse a URDF xacro file in ROS 2, for example from within a .launch.py script? |
|
I would also like to see an example of using a xacro file in a launch.py script. I have been trying to use it in dashing like this: This errors on a call to get_path() in substitution_args.py. I can get past that by importing rospkg and uncommenting some code in _get_rospack(). But then I'm just stuck on another error. |
Your method should work, but the underlying issue (as @rhaschke mentioned) is that the version of |
|
Changes on #211 |
Ported xacro package to ROS2 and tested it on ROS2 version bouncy and crystal.
@rhaschke, Could you please review it and give your feedback ?