Find console_bridge without explicit version#141
Conversation
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
chapulina
left a comment
There was a problem hiding this comment.
LGTM. Just curious, why still default to 0.3?
changing a minimum required dependency should require a version bump; I wanted this to be a minimal change |
|
Can we just remove the explicit version completely? Particularly since there isn't an API break between 0.3 and 1.0, I think we can just do: And be done with it. What do you think? |
That's a good point; I had left it in because it was initially ensuring that we had at least version 0.3 so that we could use the namespaces logging macros (see #73), but that was several years ago, and even Ubuntu 16.04 has 0.3, so yes, I think we can drop the explicit version now |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
dropped explicit version requirement in b18a97b |
* urdfdom used in melodic isn't compatible with 1.0.0 version used by ROS2 distributions and fails with: | -- Found TinyXML: ros1-melodic-thud/tmp-glibc/work/core2-64-oe-linux/urdfdom/1.0.0-2-r0/recipe-sysroot/usr/lib/libtinyxml.so | CMake Error at CMakeLists.txt:44 (find_package): | Could not find a configuration file for package "console_bridge" that is | compatible with requested version "0.3". | | The following configuration files were considered but not accepted: | | ros1-melodic-thud/tmp-glibc/work/core2-64-oe-linux/urdfdom/1.0.0-2-r0/recipe-sysroot/usr/lib/console_bridge/cmake/console_bridge-config.cmake, version: 1.0.0 Signed-off-by: Martin Jansa <martin.jansa@lge.com>
We just released console_bridge 1.0, but urdfdom fails to find it when searching for version
0.3. This searches for 1.0 if 0.3 is not found.First noticed the failure in Homebrew/homebrew-core#55355