Merged
Conversation
clalancette
approved these changes
Nov 6, 2018
Contributor
clalancette
left a comment
There was a problem hiding this comment.
This looks OK to me.
(CI is clearly failing here because ros/urdfdom_headers#47 is not yet merged; I expect it will start succeeding once that is in place)
Contributor
Author
|
It was actually quite hard to get it to fail, so yes, it fails on purpose |
Contributor
|
I've tested this against that urdfdom_headers branch, and the test passes, so I will merge it and then revert the travis script back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test for color parsing. To check locale dependent issues it adds the Dutch locale to the travis environment and then runs tests both with LC_ALL=C and LC_ALL=nl_NL.UTF-8
With the current version of urdfdom_headers this is expected to fail for Dutch but not for "Classic". ros/urdfdom_headers#47 should fix it for Dutch (and other European languages)
Please squash on merge