Skip to content

Using wrong headers #147

@audrow

Description

@audrow

This issue is a continuation of the issue described in ros2#23. Here is its main description:

When enabling warnings in #22, it seems enabling -Wpedantic enabled -Wgnu-zero-variadic-macro-arguments in Clang which raised the following warning (as noted here, ros2#22 (comment)):

[  3%] Building CXX object urdf_parser/CMakeFiles/urdfdom_model.dir/src/pose.cpp.o
In file included from /Users/osrf/jenkins-agent/workspace/ci_osx/ws/src/ros2/urdfdom/urdf_parser/src/pose.cpp:42:
/usr/local/include/console_bridge/console.h:67:88: warning: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Wgnu-zero-variadic-macro-arguments]
  console_bridge::log(__FILE__, __LINE__, console_bridge::CONSOLE_BRIDGE_LOG_ERROR, fmt, ##__VA_ARGS__)

Two things from this warning:

  • the console bridge is being included from usr/local, and
  • it is an older version of console_bridge (not 1.0.1), because the PR fix clang warnings console_bridge#64 hasn't been applied yet.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions