Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Fixed inverted result code check in new TinyXML-2 code#70

Merged
dirk-thomas merged 1 commit intoros:lunar-develfrom
racko:lunar-devel
Feb 27, 2017
Merged

Fixed inverted result code check in new TinyXML-2 code#70
dirk-thomas merged 1 commit intoros:lunar-develfrom
racko:lunar-devel

Conversation

@racko
Copy link
Copy Markdown
Contributor

@racko racko commented Feb 26, 2017 

$ rospack profile       
terminate called after throwing an instance of 'rospack::Exception'
  what():  error parsing manifest of package rviz at /usr/share/ros_packages/rviz/package.xml

Actually XMLDocument::LoadFile returned XML_SUCCESS (== 0), but the current implementation throws an exception if LoadFile returns 0.

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Feb 27, 2017

Thank you for the quick fix.

@dirk-thomas dirk-thomas merged commit 9e4a5eb into ros:lunar-devel Feb 27, 2017
This was referenced Feb 27, 2017
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@racko @dirk-thomas