Skip to content

rosdep: Added libexiv2-dev#43463

Merged
clalancette merged 4 commits intoros:masterfrom
peci1:patch-20
Nov 18, 2024
Merged

rosdep: Added libexiv2-dev#43463
clalancette merged 4 commits intoros:masterfrom
peci1:patch-20

Conversation

@peci1
Copy link
Copy Markdown
Contributor

@peci1 peci1 commented Nov 12, 2024 •
edited
Loading

Please add the following dependency to the rosdep database.

Package name:

libexiv2-dev

Package Upstream Source:

https://www.exiv2.org/

Purpose of using this:

Development files for exiv2.

Distro packaging links:

Links to Distribution Packages

@peci1 peci1 requested a review from a team as a code owner November 12, 2024 00:56
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Nov 12, 2024
@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Nov 12, 2024

There's a lint warning that suggests an OpenSUSE name for it, can you check that?

@wjwwood wjwwood added the more information needed Maintainers have asked for additional information label Nov 12, 2024
@peci1
Copy link
Copy Markdown
Contributor Author

peci1 commented Nov 12, 2024

Thanks for spotting it. Added.

@sloretz sloretz removed the more information needed Maintainers have asked for additional information label Nov 15, 2024
This was referenced Nov 16, 2024
Merged
Closed
clalancette
clalancette requested changes Nov 18, 2024
View reviewed changes
clalancette
clalancette approved these changes Nov 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented Nov 18, 2024

This now needs a rebase to fix conflicts; once that is done it will be good to merge.

@peci1 peci1 changed the title rosdep: Added exiv2-dev rosdep: Added libexiv2-dev Nov 18, 2024
@peci1
Copy link
Copy Markdown
Contributor Author

peci1 commented Nov 18, 2024

@clalancette I'm on phone only now so rebasing would be difficult. Could you squash merge? Also, CI timed out, can you rerun it?

@clalancette clalancette merged commit a24be1a into ros:master Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clalancette clalancette clalancette approved these changes

@sloretz sloretz sloretz approved these changes

Assignees

No one assigned

Labels

rosdep Issue/PR is for a rosdep key

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peci1 @wjwwood @clalancette @sloretz