Merged
Conversation
The situation with octomap and ROS is complicated. As it stands, we effectively have a "vendor" package of octomap released into Humble, Iron, Jazzy, and Rolling. However, this is a problem on Jazzy and Rolling on Ubuntu 24.04 since the ABI between what we have released, and what is released in the operating system as "liboctomap-dev" is different. That means that using it with downstream packages just doesn't work. The intent here is to add this key in, and then remove octomap from all of Humble, Iron, Jazzy, and Rolling. This will avoid the ABI problem, and just use the system package everywhere. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
audrow
approved these changes
Jun 14, 2024
Contributor
audrow
left a comment
There was a problem hiding this comment.
Looks good with happy PR jobs.
marcoag
approved these changes
Jun 24, 2024
This was referenced Jun 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The situation with octomap and ROS is complicated.
As it stands, we effectively have a "vendor" package of octomap released into Humble, Iron, Jazzy, and Rolling. However, this is a problem on Jazzy and Rolling on Ubuntu 24.04 since the ABI between what we have released, and what is released in the operating system as "liboctomap-dev" is different. That means that using it with downstream packages just doesn't work.
The intent here is to add this key in, update all downstream packages to use this key, and then remove octomap from all of Humble, Iron, Jazzy, and Rolling. This will avoid the ABI problem, and just use the system package everywhere.
See #41622 for more information.
Note that I expect CI on this to fail until https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-71ae26cb75 lands in EPEL-9, about a week from now.
Please add the following dependency to the rosdep database.
Package name:
liboctomap-dev
Package Upstream Source:
https://github.com/octomap/octomap
Purpose of using this:
See the explanation above.
Several packages depend on having octomap available, including:
Links to Distribution Packages