Set clang-format key to clang-tools-extra on RHEL#41591
Conversation
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
cottsay
left a comment
There was a problem hiding this comment.
Thanks, it looks like fedora is in the same boat. Mind fixing that as well?
https://packages.fedoraproject.org/pkgs/clang/clang-tools-extra/
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Oops, I didn't commit that part. Fixed.
Done! It looks like it might be the same for alpine too, but I can only find packages with the |
rosdep/base.yaml
Outdated
| arch: [clang] | ||
| debian: [clang-format] | ||
| fedora: [clang] | ||
| fedora: [clang-tools-extra] |
There was a problem hiding this comment.
If we look at what binaries the clang-format tools provides on Ubuntu, it looks like it provides all of:
/usr/bin/clang-format
/usr/bin/clang-format-diff
/usr/bin/git-clang-format
On RHEL and Fedora, clang-tools-extra provides both clang-format and clang-format-diff, while git-clang-format comes in via the git-clang-format package.
Thus it seems to me that this should be:
| fedora: [clang-tools-extra] | |
| fedora: [clang-tools-extra, git-clang-format] |
(the same goes for the rhel key below)
There was a problem hiding this comment.
makes sense, done
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me, but I'd like to get @cottsay 's approval again for the latest changes before merging.
Please add the following dependency to the rosdep database.
Package name:
Set
clang-formattoclang-tools-extraon RHEL.Package Upstream Source:
N/A
Purpose of using this:
ros-jazzy-ament-clang-formatdepends onclang-formaton Ubuntu, but not on RHEL. The rosdep entry forclang-formaton RHEL isclang, which does not provideclang-format. The RHEL package that providesclang-formatis apparentlyclang-tools-extra: ros-tooling/setup-ros#694 (comment).Since
clang-tidyalso maps toclang-tools-extraon RHEL and skips RHEL 7, I've done the same forclang-format.Links to Distribution Packages