Skip to content

Revert "mavlink: 2023.5.5-1 in 'melodic/distribution.yaml' [bloom] (#…#37469

Merged
clalancette merged 1 commit intomasterfrom
clalancette/revert-melodic-mavlink
Jun 5, 2023
Merged

Revert "mavlink: 2023.5.5-1 in 'melodic/distribution.yaml' [bloom] (#…#37469
clalancette merged 1 commit intomasterfrom
clalancette/revert-melodic-mavlink

Conversation

@clalancette
Copy link
Copy Markdown
Contributor

…37150)"

This reverts commit 18c62e1.

This has failed to build since it was merged: https://build.ros.org/job/Mbin_uB64__mavlink__ubuntu_bionic_amd64__binary/ . FYI @vooon

@github-actions github-actions bot added the melodic Issue/PR is for the ROS 1 Melodic distribution label Jun 5, 2023
@clalancette clalancette merged commit e6cac16 into master Jun 5, 2023
@clalancette clalancette deleted the clalancette/revert-melodic-mavlink branch June 5, 2023 15:17
@vooon
Copy link
Copy Markdown
Contributor

vooon commented Jun 5, 2023

I haven't noticed that upstream break compatibility. But likely 06.06 be ok, working on it.

@vooon
Copy link
Copy Markdown
Contributor

vooon commented Jun 5, 2023

@clalancette i've updated patches and can confirm build for Noetic and Iron. But i'm unsure if that's good idea to release for Melodic, as i EOL and i haven't tested for Python 2.

So tomorrow i'm going to release for Noetic, Humble, Iron and Rolling. Is i'm right?

@clalancette
Copy link
Copy Markdown
Contributor Author

So tomorrow i'm going to release for Noetic, Humble, Iron and Rolling. Is i'm right?

That seems reasonable to me, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

melodic Issue/PR is for the ROS 1 Melodic distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants