Skip to content

Cleanup rosdep rules for long EOL Ubuntu and Debian distros#36755

Merged
tfoote merged 28 commits intomasterfrom
clear-eol-rules
Apr 14, 2023
Merged

Cleanup rosdep rules for long EOL Ubuntu and Debian distros#36755
tfoote merged 28 commits intomasterfrom
clear-eol-rules

Conversation

@tfoote
Copy link
Copy Markdown
Member

@tfoote tfoote commented Apr 11, 2023

This is a repository cleanup. I have removed all the specific rules for ubuntu distros older than bionic and debian distros older than stretch.

This will hopefully make maintaining the rosdep database a little bit easier with fewer lines to search through.

The recommendation if you're using an older EOL platform is to use a tag of the rosdistro from the last sync of the rosdistro.

@tfoote tfoote requested a review from a team as a code owner April 11, 2023 07:16
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Apr 11, 2023
Copy link
Copy Markdown
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 to both the change itself and the documentation on our policy for EOL distros.

@tfoote
Copy link
Copy Markdown
Member Author

tfoote commented Apr 14, 2023

This was also discussed and positively reviewed in the ROS weekly meeting. I added the documentation updates based on that feedback.

@tfoote tfoote merged commit 59517bc into master Apr 14, 2023
@tfoote tfoote deleted the clear-eol-rules branch April 14, 2023 19:16
@zultron
Copy link
Copy Markdown
Contributor

zultron commented Apr 15, 2023

59517bc#diff-d8721f41777cc41754c7a34c95d1ef9c8f6fbce7575d129bcbcd32383cde667bL664

ALL Ubuntu distros removed from the python-attrs-pip keys. This must be a typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rosdep Issue/PR is for a rosdep key

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants