Skip to content

psen_scan_v2: 0.3.4-1 in 'noetic/distribution.yaml' [bloom]#31521

Merged
hidmic merged 1 commit intoros:masterfrom
martiniil:bloom-psen_scan_v2-15
Dec 22, 2021
Merged

psen_scan_v2: 0.3.4-1 in 'noetic/distribution.yaml' [bloom]#31521
hidmic merged 1 commit intoros:masterfrom
martiniil:bloom-psen_scan_v2-15

Conversation

@martiniil
Copy link
Copy Markdown
Contributor

@martiniil martiniil commented Dec 20, 2021

Increasing version of package(s) in repository psen_scan_v2 to 0.3.4-1:

psen_scan_v2

* Prevent error when diagnostics are disabled. Fix #294
* Set exception in stop-future
* Apply clang-tidy fixes to header-files. Fix #277
* Remove latched flag from active zoneset topic
* API change: convenience usage of ScannerConfiguration
* Remove unrelated parameter DEFAULT_X_AXIS_ROTATION from standalone
* Contributors: Pilz GmbH and Co. KG

hidmic
hidmic reviewed Dec 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martiniil mind to add a LICENSE file at the source repository root (as per current contribution guidelines)?

Edit: I see a LICENSES directory. Not all of them are reflected in the package.xml though. Best to sort this out now then.

@martiniil
Copy link
Copy Markdown
Contributor Author

martiniil commented Dec 22, 2021

@martiniil mind to add a LICENSE file at the source repository root (as per current contribution guidelines)?

Edit: I see a LICENSES directory. Not all of them are reflected in the package.xml though. Best to sort this out now then.

@hidmic Thanks for your comment. The entry in the package.xml is correct. But the LPLG license text is not complete on its own, it only adds to the GPL license text. So we provide both.

Is there anything more we can do to sort this out?

@hidmic
Copy link
Copy Markdown
Contributor

hidmic commented Dec 22, 2021 •
edited
Loading

But the LPLG license text is not complete on its own, it only adds to the GPL license text. So we provide both.

@martiniil I see. Putting both in a single LICENSE file is equally ad-hoc.

Nevermind then. Going in.

@hidmic hidmic merged commit 8aebd1f into ros:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hidmic hidmic hidmic left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@martiniil @hidmic