Skip to content

add wxpython for bullseye/focal#25075

Merged
clalancette merged 2 commits intoros:masterfrom
k-okada:wxpython
Aug 7, 2020
Merged

add wxpython for bullseye/focal#25075
clalancette merged 2 commits intoros:masterfrom
k-okada:wxpython

Conversation

@k-okada
Copy link
Copy Markdown
Contributor

@k-okada k-okada commented May 26, 2020 •
edited
Loading

@k-okada k-okada requested a review from a team as a code owner May 26, 2020 04:44
@k-okada k-okada mentioned this pull request May 26, 2020
Merged
@clalancette clalancette added the rosdep Issue/PR is for a rosdep key label May 26, 2020
clalancette
clalancette requested changes May 26, 2020
View reviewed changes
rosdep/python.yaml Outdated
artful: [python-wxgtk3.0]
bionic: [python-wxgtk3.0]
cosmic: [python-wxgtk3.0]
focal: [python-wxgtk3.0]
Copy link
Copy Markdown
Contributor

@clalancette clalancette May 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all of our currently-supported Ubuntu releases, the key is python-wxgtk3.0. So I think we should just replace this whole block with:

ubuntu: [python-wxgtk3.0]

Which has the added benefit of making us forwards-compatible.

Copy link
Copy Markdown
Contributor Author

@k-okada k-okada May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette thanks! chaned to keep both backward/forward compatible

clalancette
clalancette requested changes May 28, 2020
View reviewed changes
@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Jun 1, 2020

python-wxgtk3.0

Note that this Debian package depends on Python 2. It shouldn't be used in a package released into Noetic and Foxy because they are both targeting Python 3.

@k-okada
Copy link
Copy Markdown
Contributor Author

k-okada commented Jun 5, 2020

@sloretz not sure if I understand you comment correctly, python-wxgtk3. means gtk3.0 on python2. For python3 they have python3-wxgtk4.0

18.04

Package: python-wxgtk3.0
Version: 3.0.2.0+dfsg-7
Priority: optional
Section: universe/python
Source: wxpython3.0
Origin: Ubuntu
Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
Original-Maintainer: wxWidgets Maintainers <freewx-maint@lists.alioth.debian.org>
Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Installed-Size: 29.0 MB
Provides: python2.7-wxgtk3.0
Depends: python-wxversion, python (<< 2.8), python (>= 2.7~), python:any (<< 2.8), python:any (>= 2.7.5-5~), libc6 (>= 2.14), libgcc1 (>= 1:3.0), libstdc++6 (>= 5.2), libwxbase3.0-0v5 (>= 3.0.4+dfsg), libwxgtk3.0-gtk3-0v5 (>= 3.0.4+dfsg)

20.04

Package: python-wxgtk3.0
Version: 3.0.2.0+dfsg-8build1
Priority: optional
Section: universe/python
Source: wxpython3.0
Origin: Ubuntu
Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
Original-Maintainer: wxWidgets Maintainers <team+wx@tracker.debian.org>
Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Installed-Size: 30.5 MB
Provides: python2.7-wxgtk3.0
Depends: python-wxversion, python2 (<< 2.8), python2 (>= 2.7~), python2:any (<< 2.8), python2:any (>= 2.7~), libc6 (>= 2.14), libgcc1 (>= 1:3.0), libstdc++6 (>= 5.2), libwxbase3.0-0v5 (>= 3.0.4+dfsg), libwxgtk3.0-gtk3-0v5 (>= 3.0.4+dfsg-10~)

@sloretz sloretz mentioned this pull request Jun 5, 2020
Closed
@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Jun 5, 2020

@sloretz not sure if I understand you comment correctly, python-wxgtk3. means gtk3.0 on python2

Yup. Since it depends on Python 2, this rosdep key shouldn't be used by any ROS packages in ROS Noetic or ROS Foxy. If the plan was to release a ROS package into Noetic or Foxy that currently depends on the rosdep key wxpython in Melodic or earlier, it should be updated to not use the wxpython rosdep key, but instead use a (to be created) python3-wxgtk4.0 rosdep key.

@Timple Timple mentioned this pull request Jul 24, 2020
Merged
nuclearsandwich
nuclearsandwich approved these changes Aug 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette has requested a simplification which is only possible by dropping distributions which are no longer supported. I'm in general in favor of that but also fine honoring specific requests from contributors to maintain current levels of support in our rosdep db.

Which is to say, I don't think we should add new keys, or restore dropped keys for older distributions on request since we can instead push individuals who need those to custom rosdep sources. But I don't see a problem with delaying the reduction of support based on contributor feedback.

@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented Aug 7, 2020

Which is to say, I don't think we should add new keys, or restore dropped keys for older distributions on request since we can instead push individuals who need those to custom rosdep sources. But I don't see a problem with delaying the reduction of support based on contributor feedback.

That logic works for me. I'll re-review here.

@clalancette clalancette merged commit dabab82 into ros:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clalancette clalancette clalancette approved these changes

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

+1 more reviewer

@Timple Timple Timple left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

rosdep Issue/PR is for a rosdep key

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@k-okada @sloretz @clalancette @nuclearsandwich @Timple