Closed
Conversation
tfoote
requested changes
Jan 31, 2019
Member
There was a problem hiding this comment.
If this is targeted for ros_comm it must have native packages on all platforms and not pip packages. The pip dependencies cannot be used when being built into native packages, only when building from source.
Also please link to the packages online in the body of the PR for easier review.
Member
|
Since the referenced PR in ros_comm is not going to be merge we could just close this PR (if there is no other use case this is intended for). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pycryptodome which is need by ros/ros_comm#1609