This repository was archived by the owner on May 31, 2025. It is now read-only.
Fixing logic issue causing cache not to be saved properly.#931
Closed
bponsler wants to merge 1 commit intoros:indigo-develfrom
Closed
Fixing logic issue causing cache not to be saved properly.#931bponsler wants to merge 1 commit intoros:indigo-develfrom
bponsler wants to merge 1 commit intoros:indigo-develfrom
Conversation
Merged
Member
|
Sorry for the late response. Thank you for your patch. I finally got around to take a closer look. I created #966 as a replacement which targets the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The returns were causing the logic to save the cache never execute when a executable/resource was successfully located. This change reduced the XML parsing/loading process for my launch file from ~15 seconds to < 1 second.