This repository was archived by the owner on May 31, 2025. It is now read-only.
need to consider test_depends for calculate_missing?#885
Closed
k-okada wants to merge 1 commit intoros:indigo-develfrom
Closed
need to consider test_depends for calculate_missing?#885k-okada wants to merge 1 commit intoros:indigo-develfrom
test_depends for calculate_missing?#885k-okada wants to merge 1 commit intoros:indigo-develfrom
Conversation
Member
|
I don't think considering test dependencies is reasonable here. In the common case where you install a launch file and use this check to ensure that "it will work" (aka all its dependencies are available) test dependencies are generally not available. So the test would pass but the launch file would fail if the Debian package (which doesn't depend on test dependencies) is being installed. |
Contributor
Author
|
ok, how about #887, use |
Member
|
That sounds much better. Closing this in favor of #887. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see discussion ros-infrastructure/ros_buildfarm#341 (comment)