Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

[rostopic] Get parent topics (upstream in pipeline) with rostopic hz#874

Closed
wkentaro wants to merge 2 commits intoros:kinetic-develfrom
wkentaro:rostopic-hz-search-parent
Closed

[rostopic] Get parent topics (upstream in pipeline) with rostopic hz#874
wkentaro wants to merge 2 commits intoros:kinetic-develfrom
wkentaro:rostopic-hz-search-parent

Conversation

@wkentaro
Copy link
Copy Markdown
Contributor

Moved from #718
to send PR to K

@wkentaro wkentaro force-pushed the rostopic-hz-search-parent branch from a5b29cc to 77b3bac Compare August 24, 2016 14:27
@wkentaro wkentaro changed the title [rostopic] Get parent topics (upstream in pipeline) in rostopic hz [rostopic] Get parent topics (upstream in pipeline) with rostopic hz Aug 24, 2016
@dirk-thomas
Copy link
Copy Markdown
Member

Should there be a non-recursive option?

I think the documentation needs to be rephrased. I know what you mean with "the node of specified topic" but that is not very clear. Also the term parent is not that good imo. @ros/ros_team What do you think? Any better naming suggestions.

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Aug 29, 2016

If this is recursive, does it avoid cycles?

I don't have any suggestions for naming. Maybe upstream rather than parent, but upstream implies a tree to me, which again is not necessarily the case.

@dirk-thomas
Copy link
Copy Markdown
Member

upstream sounds like a better term to me too.

Get topics to which the node of specified topic subscribes to.

This doc string could be more precise imo, e.g.: "Get topics to which all nodes publishing the passed topic are subscribed to."

When thinking about this more the logic to consider upstream topics (recursively or non-recursively) could be useful beyond rostopic hz. Maybe it would be better to have a separate verb (or an existing one with special arguments) which returns that upstream topic list. And then the result of that can be passed to rostopic hz?

Anyway before integrating this feature a bug with multiple topics and rostopic hz needs to be addressed: #712 (comment)

@wkentaro
Copy link
Copy Markdown
Contributor Author

wkentaro commented Sep 19, 2016

upstream sounds like a better term to me too.

Get topics to which the node of specified topic subscribes to.
This doc string could be more precise imo, e.g.: "Get topics to which all nodes publishing the passed topic are subscribed to."

I agree.

When thinking about this more the logic to consider upstream topics (recursively or non-recursively) could be useful beyond rostopic hz. Maybe it would be better to have a separate verb (or an existing one with special arguments) which returns that upstream topic list. And then the result of that can be passed to rostopic hz?

+1
Maybe rostopic upstream /topic?

@dirk-thomas
Copy link
Copy Markdown
Member

The proposed verb name upstream sounds ok to me. @ros/ros_team Any thoughts on this?

@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Oct 21, 2016

Fine by me.

@dirk-thomas
Copy link
Copy Markdown
Member

Closing due to long time of inactivity. Please consider opening a new PR targeting the current default branch if you are still interested in getting this patch merged.

@dirk-thomas dirk-thomas closed this Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants