[rostopic] Get parent topics (upstream in pipeline) with rostopic hz#874
[rostopic] Get parent topics (upstream in pipeline) with rostopic hz#874wkentaro wants to merge 2 commits intoros:kinetic-develfrom
Conversation
a5b29cc to
77b3bac
Compare
|
Should there be a non-recursive option? I think the documentation needs to be rephrased. I know what you mean with "the node of specified topic" but that is not very clear. Also the term |
|
If this is recursive, does it avoid cycles? I don't have any suggestions for naming. Maybe upstream rather than parent, but upstream implies a tree to me, which again is not necessarily the case. |
|
This doc string could be more precise imo, e.g.: "Get topics to which all nodes publishing the passed topic are subscribed to." When thinking about this more the logic to consider upstream topics (recursively or non-recursively) could be useful beyond Anyway before integrating this feature a bug with multiple topics and |
I agree.
+1 |
|
The proposed verb name |
|
Fine by me. |
|
Closing due to long time of inactivity. Please consider opening a new PR targeting the current default branch if you are still interested in getting this patch merged. |
Moved from #718
to send PR to K