This repository was archived by the owner on May 31, 2025. It is now read-only.
Allow 64-bit sizes to be passed to robag max_size#865
Merged
dirk-thomas merged 1 commit intoros:kinetic-develfrom Aug 12, 2016
Merged
Allow 64-bit sizes to be passed to robag max_size#865dirk-thomas merged 1 commit intoros:kinetic-develfrom
dirk-thomas merged 1 commit intoros:kinetic-develfrom
Conversation
Member
|
@ros-pull-request-builder retest this please |
Member
|
Thank you for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internally, bagfile size is 64 bits. However, the types used in command parsing are only 32 bits, making the maximum usable split size 2GB. This patch switches the argument parsing to use 64 bit types.