This repository was archived by the owner on May 31, 2025. It is now read-only.
[rostest] Refactor hztestX.test#862
Merged
dirk-thomas merged 3 commits intoros:kinetic-develfrom Aug 24, 2016
Merged
Conversation
2a01baa to
47db21c
Compare
Member
|
Please add more information to the pull request describing why you want this to be changed. |
Contributor
Author
|
Updated the information. |
Member
|
For new ROS users I would expect the previous way of setting the parameters to be easier and much less error prone. Each parameter is very simple and separate from the others. Using |
Contributor
Author
|
Your comments are reasonable, but in the first look, I thought the |
This reverts commit 47db21c.
7c13ea7 to
3549e78
Compare
Contributor
Author
|
Fixed. |
Member
|
Looks good to me. Thanks!. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The files hztestX.test are the samples for ROS users for testing nodes.
This PR simplify the test xml to demonstrate how to use
<rosparam>for private params.