This repository was archived by the owner on May 31, 2025. It is now read-only.
Fix str conversion in encode_ros_handshake_header#786
Closed
benureau wants to merge 0 commit intoros:kinetic-develfrom
benureau:kinetic-devel
Closed
Fix str conversion in encode_ros_handshake_header#786benureau wants to merge 0 commit intoros:kinetic-develfrom benureau:kinetic-devel
benureau wants to merge 0 commit intoros:kinetic-develfrom
benureau:kinetic-devel
Conversation
Contributor
Author
|
I realised too late that I was removing a lot of trailing whitespaces. Tell me if you want a cleaner commit. |
Member
|
Thanks for the pull request. Yes, please remove any unrelated white space changes from the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code was not properly filtering unicode/str out of the header. Added the corresponding unit test.