This repository was archived by the owner on May 31, 2025. It is now read-only.
evaluation of expressions in roslaunch#627
Closed
rhaschke wants to merge 0 commit intoros:indigo-develfrom
Closed
Conversation
Member
|
Can one of the admins verify this patch? |
25933e5 to
704da6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The evaluation capabilities of roslaunch are currently rather limited.
Particularly, the conditionals of
if/unlesstags are only evaluated w.r.t. 0,1,true,false. Having more general expressions, e.g. general comparison ($(arg foo) == 'bar') would be great.The same applies for definition of
argvalues.This PR proposes a simple solution to both problems.
Instead of limiting the extensions to
ifunless_test()and_arg_tag(), but integrating them intoxmlloader.opt_attrs()one could enable expression evaluation for all attributes.