This repository was archived by the owner on May 31, 2025. It is now read-only.
add prefix option for prefixing output topics#626
Closed
Karsten1987 wants to merge 3 commits intoros:indigo-develfrom
Closed
add prefix option for prefixing output topics#626Karsten1987 wants to merge 3 commits intoros:indigo-develfrom
Karsten1987 wants to merge 3 commits intoros:indigo-develfrom
Conversation
Member
|
Can one of the admins verify this patch? |
Member
Member
|
Test passed. |
Member
|
I am sorry for not replying earlies to this. I will add a few comments inline. Afterwards this should be merged. |
tools/rosbag/src/play.cpp
Outdated
Member
There was a problem hiding this comment.
The short option can't be q since that is already used for quiet.
Member
|
Test passed. |
Member
|
I squashed and cherry picked your patch in 9d84d99. I avoided any unrelated white space changes and quoted the printed prefix: 9d84d99#diff-31811e9a65852f77641456619ddfc878R146 |
This was referenced Mar 17, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prefix option allows to publish all topics with the given string prefix.
Use cases are e.g. playing a rosbag and the original source at the same time comparing the two outcomes simultaneously without topic conflicts.