And the fix comes.

Is there actually reason to copy the whole stats structure twice in each callback? Wouldn't it be better to modify it directly via an auto&? Could the reason be keeping the lists consistent even in usage by different threads? But that would mean some data would be lost if more threads were overwriting the stats structure...

@mjcarroll @sloretz friendly ping

Thank you for the PR!

ROS Noetic will reach end-of-life on May 31st, 2025. Every change comes with a risk of introducing regressions, and there isn't much time left to fix them. To make sure this PR doesn't introduce any regressions please:

• Describe how you tested this change
• Recruit at least one more person to review this PR and try it out on their system

This PR comes with a unit test that fails without this PR and succeeds with it. The test does something that should be completely valid - having topic statistics enabled, receiving lots of messages and then resetting ROS time back.

ROS 1 is end-of-life (EOL) as of today, May 31st 2025. I am archiving this repository because:

• it only supports ROS 1
• it isn't needed anymore in ROS 2

If you still rely on ROS 1, read this page to learn about your options.