Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Fix throttle publish first message#2088

Closed
efernandez wants to merge 4 commits intoros:noetic-develfrom
efernandez:fix-throttle-publish-first-message
Closed

Fix throttle publish first message#2088
efernandez wants to merge 4 commits intoros:noetic-develfrom
efernandez:fix-throttle-publish-first-message

Conversation

@efernandez
Copy link
Copy Markdown
Contributor

@efernandez efernandez commented Nov 6, 2020

Follow up PR for #1943

This adds two more commits that fix the test and a potential bug:

  • Wait for throttle_publishtest subscriber
  • Resolve output topic name when waiting for subscribers

... before publishing the first message, so it does not get lost.
This is important so the first message is received by the subscribers,
otherwise it is always lost.
@efernandez
Copy link
Copy Markdown
Contributor Author

@dirk-thomas This updates #1943, providing the changes requested

@dirk-thomas
Copy link
Copy Markdown
Member

@dirk-thomas This updates #1943, providing the changes requested

@efernandez Sorry, I am not the maintainer of this repo anymore.

@efernandez
Copy link
Copy Markdown
Contributor Author

@fujitatomoya @jacobperron I've seen you've reviewed some recent PRs, so I wonder if you could help me reviewing this one or finding someone that could do so. Thanks.

@efernandez
Copy link
Copy Markdown
Contributor Author

pinging @jacobperron

I'd like to know your thoughts on this.

@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Apr 25, 2025

Thank you for the PR!

ROS Noetic will reach end-of-life on May 31st, 2025. Every change comes with a risk of introducing regressions, and there isn't much time left to fix them. To make sure this PR doesn't introduce any regressions please:

  • Describe how you tested this change
  • Recruit at least one more person to review this PR and try it out on their system

@sloretz sloretz closed this May 31, 2025
@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented May 31, 2025

ROS 1 is end-of-life (EOL) as of today, May 31st 2025. I am archiving this repository because:

  • it only supports ROS 1
  • it isn't needed anymore in ROS 2

If you still rely on ROS 1, read this page to learn about your options.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants