This repository was archived by the owner on May 31, 2025. It is now read-only.
[Melodic Backport] set call_finished_ with true for each call inside callFinished (#2074)#2080
Closed
iuhilnehc-ynos wants to merge 1 commit intoros:melodic-develfrom
Closed
Conversation
) * set call_finished_ with true for each call inside callFinished and also set current_call flags when failure happens Signed-off-by: Chen Lihui <lihui.chen@sony.com> * Update based on review Co-authored-by: Tomoya.Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com> * set the flag with true again even if it is true already Signed-off-by: Chen Lihui <lihui.chen@sony.com> Co-authored-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Contributor
|
i think this wont be necessary, see #1496. i guess that you can close this PR. |
Member
|
Closing in favor of #2074 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and also set current_call flags when failure happens
Signed-off-by: Chen Lihui lihui.chen@sony.com
Co-authored-by: Tomoya.Fujita Tomoya.Fujita@sony.com
Signed-off-by: Chen Lihui lihui.chen@sony.com
Signed-off-by: Chen Lihui lihui.chen@sony.com
Co-authored-by: Tomoya.Fujita Tomoya.Fujita@sony.com