This repository was archived by the owner on May 31, 2025. It is now read-only.
changes between 1.15.4 (Noetic) and 1.14.4 for backporting into Melodic#1917
Merged
dirk-thomas merged 9 commits intomelodic-develfrom Mar 20, 2020
Merged
changes between 1.15.4 (Noetic) and 1.14.4 for backporting into Melodic#1917dirk-thomas merged 9 commits intomelodic-develfrom
dirk-thomas merged 9 commits intomelodic-develfrom
Conversation
* add assertion to narrow down error case * update test to ignore messages which are insufficient
…ness (#1897) * increase time limit of publishtest.test to reduce flakyness * increase time limit of advertisetest.test to reduce flakyness
Signed-off-by: Miaofei <miaofei@amazon.com>
macOS was incorrectly attempting to use epoll/poll instead of kqueue, occassionally generating errors such as RuntimeError: concurrent poll() invocation and breaking python nodes. Co-authored-by: Steve Nogar <snogar@gmail.com>
Prevent python nodes from spamming the terminal every time a node is quit. Noted in Python 3 running on macOS. Co-authored-by: Steve Nogar <snogar@gmail.com>
Contributor
|
This backport added Python3 only code to melodic branch: https://github.com/ros/ros_comm/pull/1917/files#diff-2657ef9f5903b672eeb4e9537e18bdc75de0542f6703cc160e184a889a077ff5R157 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following list of changes has been integrated into ros_comm 1.15.4 (Noetic) since the last Melodic release (1.14.4).
Backported: (these changes are part of this PR)
update test to pass with old and new yaml (update test to pass with old and new yaml #1893)
fix flakyness of transform test (fix flakyness of transform test #1890)
fix dictionary changed size during iteration (fix dictionary changed size during iteration #1894)
fix flakyness of test_topic_statistics (fix flakyness of test_topic_statistics #1896)
increase time limit of advertisetest/publishtest.test to reduce flakyness (increase time limit of advertisetest/publishtest.test to reduce flakyness #1897)
make statistics.test less flaky (make statistics.test less flaky #1899)
Fix "Unable to report rosout: exit" (Fix "Unable to report rosout: __exit__" #1915)
Fix mac rospy polling issue (Fix mac rospy polling issue #1907)
Fix Python 3 mac uncaught exception (Fix Python 3 mac uncaught exception #1908)
Not backported:
wrap rostest call to add
pythonpointing to sys.executable in PATH ([noetic] wrap rostest call to addpythonpointing to sys.executable in PATH #1879)use setuptools instead of distutils Use setuptools instead of distutils #1870
fix missing boost dependencies (fix missing boost dependencies #1895)
Add timestamp formatting for rosconsole (Add timestamp formatting for rosconsole #1892)
export missing Boost dependency (export missing Boost dependency #1898)
remove Boost version check since Noetic only targets platforms with 1.67+ (remove Boost version check since Noetic only targets platforms with 1.67+ #1903)
Restrict boost dependencies to components used ([noetic] Restrict boost dependencies to components used #1871)