Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

[Windows] use double quotes for portable roslaunch-check command.#1883

Merged
dirk-thomas merged 1 commit intoros:melodic-develfrom
seanyen:patch-3
Feb 20, 2020
Merged

[Windows] use double quotes for portable roslaunch-check command.#1883
dirk-thomas merged 1 commit intoros:melodic-develfrom
seanyen:patch-3

Conversation

@seanyen
Copy link
Copy Markdown
Contributor

@seanyen seanyen commented Feb 15, 2020 •
edited
Loading

On Windows, the single quotes will be passed the executable and won't be escaped. In this case, it causes that this line always returns None and throws exceptions like below.

ros_comm/tools/roslaunch/scripts/roslaunch-check

Line 88 in 902fb00

pkg = rospkg.get_package_name(roslaunch_path) 

Traceback (most recent call last):
  File "C:\opt\ros\melodic\x64\share\roslaunch\scripts\roslaunch-check", line 90, in <module>
    pkg_dir = r.get_path(pkg)
  File "C:\opt\python27amd64\lib\site-packages\rospkg\rospack.py", line 203, in get_path
    raise ResourceNotFound(name, ros_paths=self._ros_paths)
rospkg.common.ResourceNotFound: <exception str() failed>

@seanyen
Copy link
Copy Markdown
Contributor Author

seanyen commented Feb 18, 2020

@dirk-thomas This is ready for review and merge. Thanks!

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Feb 19, 2020

@ros-pull-request-builder retest this please

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Feb 20, 2020

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit 7ad4625 into ros:melodic-devel Feb 20, 2020
@dirk-thomas dirk-thomas mentioned this pull request Aug 4, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seanyen @dirk-thomas