This repository was archived by the owner on May 31, 2025. It is now read-only.
[roslaunch] Add ignore default args option to roslaunch-check#1788
Merged
dirk-thomas merged 8 commits intoros:melodic-develfrom Feb 8, 2020
Merged
[roslaunch] Add ignore default args option to roslaunch-check#1788dirk-thomas merged 8 commits intoros:melodic-develfrom
dirk-thomas merged 8 commits intoros:melodic-develfrom
Conversation
Member
|
Just FYI for reviewers, we've been running tests using this PR (on ROS Kinetic, not Melodic) at Plus One Robotics and we'll keep doing so. We're also working on setting up any publicly visible test results (which I hope doesn't block the review). |
Contributor
|
The name of the new flag is a bit misleading, right? It does not ignore default arguments but ignores not set arguments. |
Contributor
Author
Maybe something like |
Contributor
Yes, this is better! |
130s
reviewed
Nov 28, 2019
Member
|
Thanks for the patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #953
Adds an option to roslaunch-check to ignore the error thrown when a
<arg>is declared but doesn't have a default variable.Usage
From the roslaunch-check script:
rosrun roslaunch roslaunch-check [-i / --ignore-default-args] foo.launchFrom a CMakeLists.txt file:
roslaunch_add_file_check(launch/foo.launch IGNORE_DEFAULT_ARGS)Example
The example given is as follows:
which, when run with roslaunch-check, will output
The change adds an option to ignore this error with
-ior--ignore-default-argslike so