This repository was archived by the owner on May 31, 2025. It is now read-only.
Merged
Conversation
…endency declared on it
e7fe170 to
c786503
Compare
Member
Author
|
The CI failure is due to a test known to be flaky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically all cases tried to use resources they don't depend on and there are not guaranteed to be accessible when building / testing only with the declared dependencies.
See #863 (comment) where one of the cases was introduced. In that case this patch only fixes the testing but the missing dependency at runtime is still a problem.