Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Fix for issue 1441#1442

Merged
dirk-thomas merged 1 commit intoros:melodic-develfrom
pbaughman:issue_1441_rosout_formatting
Aug 3, 2018
Merged

Fix for issue 1441#1442
dirk-thomas merged 1 commit intoros:melodic-develfrom
pbaughman:issue_1441_rosout_formatting

Conversation

@pbaughman
Copy link
Copy Markdown

@pbaughman pbaughman commented Jun 22, 2018

Suggested fix for #1441

Use the logger.Handler's format method so that by default stack traces
are included in the log message if exc_info is set on the LogRecord

Fix for issue 1441
b092efa 
Use the logger.Handler's format method so that by default stack traces
are included in the log message if exc_info is set on the LogRecord
@tfoote
Copy link
Copy Markdown
Member

tfoote commented Jun 22, 2018

Hmm there was a rosbag error off by one on stretch only that seems like it should be unreleated.

1967 != 1968
  File "/usr/lib/python2.7/unittest/case.py", line 329, in run
    testMethod()
  File "/tmp/catkin_workspace/src/ros_comm/test/test_rosbag/bag_migration_tests/test/random_play.py", line 113, in test_random_play
    self.assertEqual(len(self.input), rmg.message_count())
  File "/usr/lib/python2.7/unittest/case.py", line 513, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual
    raise self.failureException(msg)

@ros-pull-request-builder retest this please.

@tfoote
Copy link
Copy Markdown
Member

tfoote commented Jun 27, 2018

The CI passed on a retest.

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Aug 3, 2018

Thank you for the improvement.

@dirk-thomas dirk-thomas merged commit cbec901 into ros:melodic-devel Aug 3, 2018
@pbaughman pbaughman deleted the issue_1441_rosout_formatting branch August 3, 2018 23:06
@dirk-thomas dirk-thomas mentioned this pull request Aug 9, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pbaughman @tfoote @dirk-thomas