This repository was archived by the owner on May 31, 2025. It is now read-only.
adding decompress to free(state) before return#1293
Closed
aswinthomas wants to merge 2 commits intoros:indigo-develfrom
aswinthomas:decompress-free-before-return
Closed
adding decompress to free(state) before return#1293aswinthomas wants to merge 2 commits intoros:indigo-develfrom aswinthomas:decompress-free-before-return
aswinthomas wants to merge 2 commits intoros:indigo-develfrom
aswinthomas:decompress-free-before-return
Conversation
tfoote
reviewed
Jan 2, 2018
utilities/roslz4/src/lz4s.c
Outdated
| ret = roslz4_compressStart(&stream, block_size_id); | ||
| if (ret != ROSLZ4_OK) { return ret; } | ||
| if (ret != ROSLZ4_OK) { | ||
| roslz4_decompressEnd(&stream); |
Member
There was a problem hiding this comment.
This doesn't look symmetric should it be roslz4_compressEnd?
Author
There was a problem hiding this comment.
Ah Yes! Thanks for catching this
Member
|
LGTM |
Member
|
Thank you for the patch. I am closing this in favor of #1313 which uses your patch but targets the latest development branch. @aswinthomas please see the discussion / comments on the new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
roslz4_compressEnd(&stream)androslz4_decompressEnd(&stream)to avoid a potential memory leak