This repository was archived by the owner on May 31, 2025. It is now read-only.
use namespaced macros instead of deprecated macros#1239
Merged
mikepurvis merged 1 commit intoros:lunar-develfrom Nov 19, 2017
Merged
use namespaced macros instead of deprecated macros#1239mikepurvis merged 1 commit intoros:lunar-develfrom
mikepurvis merged 1 commit intoros:lunar-develfrom
Conversation
Member
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rest of rosbag uses the new namespaced macros.
Given that the old console bridge macros are undefined in:
ros_comm/tools/rosbag_storage/include/rosbag/bag.h
Lines 65 to 76 in 35d1e0d
The rest of the code base needs to use the new ones