Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

fix uri in message#1213

Merged
dirk-thomas merged 1 commit intolunar-develfrom
fix_uri
Nov 2, 2017
Merged

fix uri in message#1213
dirk-thomas merged 1 commit intolunar-develfrom
fix_uri

Conversation

@dirk-thomas
Copy link
Copy Markdown
Member

Fix regression introduced in #1026.

@mathias-luedtke
Copy link
Copy Markdown

mathias-luedtke commented Nov 2, 2017

I cannot confirm that this resolves our error, because it occurs only sporadically in our tests and I was not able to enforce it egain.
But I can confirm that this patch does not break anything.

Regarding the code: In line 100 False gets returned instead of a string.
For consistency reasons I would prefer returning None and checking for is not None.
However, both versions will work :)

@dirk-thomas
Copy link
Copy Markdown
Member Author

Thank you for checking. In order to keep the patch minimal I will keep it as-is since it will work.

@dirk-thomas dirk-thomas merged commit fa0f4b6 into lunar-devel Nov 2, 2017
@dirk-thomas dirk-thomas deleted the fix_uri branch November 2, 2017 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants