This repository was archived by the owner on May 31, 2025. It is now read-only.
rosnode: Minor fixes for compatibility with both Python 2 & 3#1166
Merged
dirk-thomas merged 1 commit intoros:lunar-develfrom Sep 15, 2017
kartikmohta:fix/rosnode-py3
Merged
rosnode: Minor fixes for compatibility with both Python 2 & 3#1166dirk-thomas merged 1 commit intoros:lunar-develfrom kartikmohta:fix/rosnode-py3
dirk-thomas merged 1 commit intoros:lunar-develfrom
kartikmohta:fix/rosnode-py3
Conversation
Member
|
Please provide a reproducible example. |
kartikmohta
commented
Sep 14, 2017
| @raise ROSNodeException: if machine name cannot be resolved to an address | ||
| @raise ROSNodeIOException: if unable to communicate with master | ||
| """ | ||
| import urlparse |
Contributor
Author
There was a problem hiding this comment.
Already imported at the top of the file so no need to import here. Moreover there is no urlparse module in Python 3.
| try: | ||
| # #3659 | ||
| errnum, msg = e | ||
| errnum, msg = e.args |
Contributor
Author
There was a problem hiding this comment.
This way allows it to work for both Python 2 & 3. socket.error is just an alias of OSError in Python 3.
Member
|
Thank you for the patch. Please include a description in future contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.