Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Fix rosbag API for Python 3#1150

Merged
dirk-thomas merged 1 commit intoros:lunar-develfrom
Shevonar:fix-rosbag-python3
Aug 23, 2017
Merged

Fix rosbag API for Python 3#1150
dirk-thomas merged 1 commit intoros:lunar-develfrom
Shevonar:fix-rosbag-python3

Conversation

@Shevonar
Copy link
Copy Markdown

Closes #1047

This commit addresses the remaining issues of #1048.

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Aug 22, 2017

Can you please target the branch of @nstiurca with this PR. Then @nstiurca can merge the change into his fork and #1048 can be retested in its updated state.

@Shevonar
Copy link
Copy Markdown
Author

I actually don't see the need to involve @nstiurca, as my branch is not forked from his branch and supersedes his changes. Nevertheless I opened nstiurca#1 if it helps the process.

@dirk-thomas
Copy link
Copy Markdown
Member

I accidentally assumed your patch was addressing the remaining comment on #1048 but relied on other parts of the patch. Now I see that this patch is "complete" on its own.

I will merge this one as is and close the previous ticket. Thanks and sorry for the extra effort.

@dirk-thomas dirk-thomas merged commit b431e22 into ros:lunar-devel Aug 23, 2017
@Shevonar
Copy link
Copy Markdown
Author

Thanks for merging. I guess my wording in the first comment was missleading.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants