Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Fixed g++ 7 fall through warnings#1139

Merged
dirk-thomas merged 1 commit intoros:lunar-develfrom
racko:fallthrough_warnings
Aug 14, 2017
Merged

Fixed g++ 7 fall through warnings#1139
dirk-thomas merged 1 commit intoros:lunar-develfrom
racko:fallthrough_warnings

Conversation

@racko
Copy link
Copy Markdown
Contributor

@racko racko commented Aug 12, 2017

No description provided.

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Aug 14, 2017

Maybe this should use a -Wimplicit-fallthrough=4 compliant comment. I would suggest // lint -fallthrough since it makes it also clear that the comments purpose is related to linting.

@racko racko force-pushed the fallthrough_warnings branch from d2b48c3 to 778f47f Compare August 14, 2017 17:10
@racko
Copy link
Copy Markdown
Contributor Author

racko commented Aug 14, 2017 

11:06:13 [test_rosbag.rosunit-r03random_play/test_random_play][FAILURE]------------------
11:06:13 False is not true
11:06:13   File "/usr/lib/python2.7/unittest/case.py", line 329, in run
11:06:13     testMethod()
11:06:13   File "/tmp/catkin_workspace/src/ros_comm/test/test_rosbag/bag_migration_tests/test/random_play.py", line 155, in test_random_play
11:06:13     self.assertTrue(abs(input_time - expect_time) < .5)
11:06:13   File "/usr/lib/python2.7/unittest/case.py", line 422, in assertTrue
11:06:13     raise self.failureException(msg)

Let's check if I can retrigger the test :)

@racko
Copy link
Copy Markdown
Contributor Author

racko commented Aug 14, 2017

@ros-pull-request-builder retest this please

@racko
Copy link
Copy Markdown
Contributor Author

racko commented Aug 14, 2017

bump

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Aug 14, 2017

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit f7b192c into ros:lunar-devel Aug 14, 2017
@dirk-thomas dirk-thomas mentioned this pull request Oct 26, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@racko @dirk-thomas