Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

Removed deprecated dynamic exception specifications#1137

Merged
dirk-thomas merged 1 commit intoros:lunar-develfrom
racko:deprecated_exception_spec_fix
Aug 14, 2017
Merged

Removed deprecated dynamic exception specifications#1137
dirk-thomas merged 1 commit intoros:lunar-develfrom
racko:deprecated_exception_spec_fix

Conversation

@racko
Copy link
Copy Markdown
Contributor

@racko racko commented Aug 12, 2017 •
edited
Loading 

.../ros_comm/tools/rosbag_storage/include/rosbag/bag_player.h:80:42: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
   BagPlayer(const std::string &filename) throw(BagException);
                                          ^~~~~
.../ros_comm/tools/rosbag_storage/src/bag_player.cpp:8:48: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
 BagPlayer::BagPlayer(const std::string &fname) throw(BagException) {
                                                ^~~~~

http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2010/n3051.html says it all:

Exception specifications have proven close to worthless in practice, while adding a measurable overhead to programs. The feature should be deprecated. The one exception to the rule is the empty throw specification which could serve a legitimate optimizing role if the requirement to call the runtime unexpected mechanism was relaxed in this case.

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Aug 14, 2017

Please provide a description with your PR to clarify why this patch is desired. The exception specification has some value.

@racko
Copy link
Copy Markdown
Contributor Author

racko commented Aug 14, 2017

Updated

I'm not sure if you get notified automatically :)

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Aug 14, 2017

I'm not sure if you get notified automatically :)

GitHub only sends emails for new comments and new commits. Edited comments and amended commits don't generate a notification. So this comment was good to notify me 👍

I agree that it makes sense to remove the exception specification. I also removed it from rostime: ros/roscpp_core#64

@dirk-thomas dirk-thomas merged commit cba914d into ros:lunar-devel Aug 14, 2017
@dirk-thomas dirk-thomas mentioned this pull request Oct 26, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@racko @dirk-thomas