Skip to content
This repository was archived by the owner on May 31, 2025. It is now read-only.

only launch core nodes if master was launched by roslaunch#1098

Merged
dirk-thomas merged 1 commit intolunar-develfrom
issue1097
Jul 14, 2017
Merged

only launch core nodes if master was launched by roslaunch#1098
dirk-thomas merged 1 commit intolunar-develfrom
issue1097

Conversation

@dirk-thomas
Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas commented Jul 12, 2017

Fixes #1097.

@dirk-thomas dirk-thomas self-assigned this Jul 12, 2017
@dirk-thomas dirk-thomas mentioned this pull request Jul 12, 2017
Closed
@mikepurvis
Copy link
Copy Markdown
Member

mikepurvis commented Jul 12, 2017

LGTM 👍

@paulbovbel
Copy link
Copy Markdown
Contributor

paulbovbel commented Jul 12, 2017

Thanks, +1

@dirk-thomas
Copy link
Copy Markdown
Member Author

dirk-thomas commented Jul 12, 2017

@ros-pull-request-builder retest this please

@dirk-thomas dirk-thomas force-pushed the issue1097 branch 3 times, most recently from e43fb6f to 705d059 Compare July 14, 2017 21:12
@dirk-thomas dirk-thomas merged commit bdc8c3d into lunar-devel Jul 14, 2017
@dirk-thomas dirk-thomas deleted the issue1097 branch July 14, 2017 21:55
@dirk-thomas
Copy link
Copy Markdown
Member Author

dirk-thomas commented Jul 14, 2017

Passing CI after merge: http://build.ros.org/view/Ldev/job/Ldev__ros_comm__ubuntu_xenial_amd64/45/

@dirk-thomas dirk-thomas mentioned this pull request Oct 26, 2017
Merged
@k-okada
Copy link
Copy Markdown
Contributor

k-okada commented Dec 9, 2017 •
edited by dirk-thomas
Loading

Just for note..., This patch changes rostest behavior, where we can find rosout node before 1.12.8, but now 'rosout' node does not started anymore, and also we do not have rosout_agg topic. Just in case someone run into same trouble...
jsk-ros-pkg/jsk_roseus@23579ba

@dirk-thomas
Copy link
Copy Markdown
Member Author

dirk-thomas commented Dec 19, 2017

This patch changes rostest behavior, where we can find rosout node before 1.12.8, but now 'rosout' node does not started anymore, and also we do not have rosout_agg topic. Just in case someone run into same trouble...

I am sorry but I don't understand you comment. Can you please elaborate the problem you are experiencing. If it is a problem with this patch we need enough information to address it. What are you running, what is the expected / desired behavior. What has changes in which version. Otherwise we can't act on it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@dirk-thomas dirk-thomas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dirk-thomas @mikepurvis @paulbovbel @k-okada